Ned Andreev

Results 290 comments of Ned Andreev

https://github.com/loadimpact/k6/issues/972 is useful to peruse before stating to implement this. And as I mention in https://github.com/loadimpact/k6/issues/972#issuecomment-651635713, the whitelist/allow-only-filter part of this seems more useful than any blocking filter.

I've increased the priority of this because its lack is causing other issues with k6. Trying to `k6 archive` a user's 22k LoC script generated by the new HAR converter...

This doesn't seem like a k6 bug, more like a babel/webpack bug :confused: Can you share a reproducible example? Maybe some git repo without any proprietary code, but with a...

Yeah, it seems like it should be a `Selection`, this is the Go code that handles it: https://github.com/grafana/k6/blob/4d5461e197aebf0903169cc3f52516c140cc3590/js/modules/k6/html/html.go#L408-L425 Thanks for opening the issue! Do you want to make PRs to...

Thanks for opening this issue! It is a bit of a duplicate of https://github.com/grafana/k6/issues/1681, but it's more targeted and something that should probably be considered for the new HTTP API...

:thinking: Indeed, the time spend decompressing the body will be measured simply because the body is decompressed on-the-fly, while it's being read from the [`http.Response`'s](https://pkg.go.dev/net/http#Response) `Body` (which is a [`io.ReadCloser`](https://pkg.go.dev/io#ReadCloser)...

Thanks for opening this issue! I think the problem is that you are not actually passing the second parameter to `client.Invoke()`, [which is supposed to be the `request`](https://k6.io/docs/javascript-api/k6-net-grpc/client/client-invoke). So we...

@c47gao, you haven't indicated that you have started work on this or that you are about to make a PR, so I don't see a reason why @theshashankpal can't work...

TestStreamLogsToLogger [seems to also be flaky](https://github.com/grafana/k6/runs/3872217805?check_suite_focus=true): ``` --- FAIL: TestStreamLogsToLogger (0.00s) --- FAIL: TestStreamLogsToLogger/RestoreConnFromLatestMessage (5.00s) logs_test.go:333: Error Trace: logs_test.go:333 logs_test.go:225 server.go:2056 server.go:2434 server.go:2888 server.go:1938 asm_amd64.s:1446 Error: Not equal: expected: time.Date(2021,...

Actually, besides addressing PR comments and maybe a few more tests, I am not sure if anything else is needed in this PR here :thinking: So I'll remove the draft...