myndzi

For what it's worth, this patch needs a little extra help. In parse_message, it should be wrapping the `prefix` stuff in `if (message.prefix)` or the like, since pings from the...

The fundamental problem, for this purpose, with promises is that they represent the _result_ of an operation. This means they are inherently not declarative. You can compose them, sure, but...

Just an extra comment related to some of the other issues: ```js console.log(Buffer.from('').constructor === Buffer); console.log(Object.getPrototypeOf(Buffer.from('')).constructor === Buffer); ``` On Node.js, this will log "true" both times. In Bun it...

This is mostly a follow-up from a Slack conversation, but I'll elaborate on the use-case: Ceph, and other storage solutions, have varying requirements. For example, Minio wants unformatted partitions too,...

+ the timestamp fixes, etc.

So if a channel has an error and I want to reconnect it, can I differentiate between when the channel is closed because of the connection being closed?

The current behavior was actually what I was hoping for. I could have tested it out, but I wanted to know if it was actually defined and reliable, if that...

Tangentially related: is there a list of potential errors somewhere? I'd like to distinguish between AMQP errors and, say, stupid typos in my source code ;) Edit: nevermind, forgot about...

I can't tell if there's a way to access these values from any error handler, but I was thinking more along the lines of a general way to identify errors...

Personally, I'd rather have an explicit distinction (Error type, or a property set on the error object, etc.) than an implicit distinction (Connection error emitted first). As you note above,...