myndzi

Results 91 comments of myndzi

> Only one thing... With your recent PRs to re-enable the CLI tests, will these new specs be picked up in CI now, or do we still need to add...

@mercmobily while addressing your comments I backed my way into a solution that just has a better separation of concerns entirely. I'm rather happier with this solution than the previous...

Nope, I'll have to look into the tedious thing later. It's probably an old node version thing.

(This needs a re-run of the one CI task - it failed on a network error updating coveralls)

I'm actually in favor of breaking up packages rather than rolling them all into one. Not just for building schemas, but also for dialects. Here's why: - The dependency graph,...

These are all test dependencies, so they aren't impactful to users of the library thankfully.

It seems like sqlite and MS SQL server supports delete with limit (top), and the rest of the supported databases don't. However, I don't see in the code that any...

I agree, but knex's API doesn't provide for a good way to do that. We'd need to know the statement type up front / first to be able to exclude...