Max Schmitt

Results 802 comments of Max Schmitt

@jovandeginste if you fix the tests, we can merge it cc @memory

Hi, it was one of my first bigger Go projects. I personally would probably archive it soon since it does not follow good Go best practices.

Hi @billimek, do you have any updates related to the admin panel integration? Do you still need more time, because the title is `WIP` prefixed.

@billimek I really appreciate your effort in this pull request, so I don't want to leave it open. Do you think I can merge it? If not, we can add...

Selectors are Playwright selectors: https://playwright.dev/docs/selectors We btw. recommend migrating to [Playwright Test](https://playwright.dev/docs/intro), since they have now [all of these matchers included by default](https://playwright.dev/docs/test-assertions).

It would also be awesome if there is a webpack plugin, that the content of the bundle will be analyzed, maybe by using such one: https://github.com/webpack-contrib/webpack-bundle-analyzer In the end only...

The values here https://github.com/mxschmitt/ui-driver-hetzner/blob/7932c861aeaa7ded4873dce3ba0c323afc7662dc/component/component.js#L48-L55 get converted to kebab case and then passed to the driver as CLI parameters. You want to add a new text field?

Friendly ping @Teemu

Applied the review feedback, sorry for the late response! Not sure if we should skip it inside the integration tests or run them - with my new implementation we run...

> Sorry for the late review. > > I've tried the PR locally and it's quite a joy to test it. Just a few nitpicks that needs to be improved....