create-vue
create-vue copied to clipboard
feat: add Playwright for end-to-end testing
Hello, 👋 Playwright is getting more and more traction over the last years and we should provide users an easy integration with the Vue ecosystem so users benefit from it. This Pull Request adds Playwright as an end-to-end testing solution like it's done for Cypress. It might make sense to throw an error if the user selects both variants for e2e testing.
We'll follow-up once the component testing story with Playwright and Vite is ready.
Thank you
cc @sodatea
Applied the review feedback, sorry for the late response! Not sure if we should skip it inside the integration tests or run them - with my new implementation we run them.
(Would also be awesome if you could "lax" the GitHub Action permissions a big, so you don't have to approve all the time here)
Sorry for the late review.
I've tried the PR locally and it's quite a joy to test it. Just a few nitpicks that needs to be improved.
No worries, was out of office myself so I did not notice at all. Applied the suggestions. Lets see what results the CI will give us.
Out of curiosity, what's the current status on this? Playwright definitely is an interesting alternative to Cypress, so having it in there as an easy-to-access option seems lovely.
@mxschmitt I wonder why this PR is closed?😕
@sodatea sorry for the huge delay, I was partially ooo back then and then I forgot about it.
Would be nice if you could enable GitHub Actions for contributors, this makes me easier to ensure its all green instead of having to wait for a maintainer to click approve.
I hope I addressed the comments, if not, please let me know!
The updates Playground PR are here: https://github.com/vuejs/create-vue-templates/pull/1
@sand4rt I rebased it!