Max Schmitt

Results 841 comments of Max Schmitt

If you are interested in contributing to the docs, you are more than welcome! The relevant file is here: https://github.com/microsoft/playwright/blob/main/docs/src/getting-started-vscode-js.md

Why are you building a test-runner, Playwright is and has already a test-runner called Playwright Test!

@mortelee this issue is about the Playwright integrated video recording feature which was added a few versions ago. Your code snippet shows the usage with playwright-video, a third-party solution to...

Try ``` await this.global.page.video().saveAs(`test-run-recordings/${this.global.expect.getState().currentTestName}.webm`); ``` which should work.

Can you provide us a repro which we can run locally? Otherwise we unfortunately can't act on it.

A script which we can run locally to reproduce your described issue.

Maybe the wrong button? Maybe no download happening when clicking on that button?

This is good, then there should be definitely be a download event dispatched! Maybe already earlier? Sorry without knowing the site its just guessing!

We can't provide next steps without knowing how your site behaves. As I said probably your download does emit already before clicking on the button. The code here https://github.com/microsoft/playwright/issues/17335#issuecomment-1246911051 looks...

The following does work for me, how did you try it? ```ts await page.goto('https://exceljet.net/excel-pivot-tables'); const [download] = await Promise.all([ page.waitForEvent('download'), page.click('text=sample data for pivot table.xlsx'), ]); console.log('Filename: ' + download.suggestedFilename());...