Max Inden

Results 900 comments of Max Inden

I believe we [fixed](https://phabricator.services.mozilla.com/D265812) this just now in Firefox itself. Basically if we do GSO and `if e.raw_os_error() == Some(libc::EIO)`, we should retry without GSO. @koujaz appreciate the report. Do...

> macOS doesn't actually support segmentation offload, so that works fine. Thanks! Nit: with `fast-apple-datapath` (https://github.com/quinn-rs/quinn/pull/1993) it does advertise it, but then actually does a larse `sendmsg_x`. Not sure this...

Given that we disabled HTTP/2 server push, should HTTP/3 server push still be on our roadmap? https://bugzilla.mozilla.org/show_bug.cgi?id=1915848

Cool! Yes, this is still wanted. Can you open a pull request with your current implementation @Hackzzila? Best to discuss with an implementation at hand.

Appreciate your curiosity! On a high level, I don't think it matters for a user whether an operation takes 40 or 20 nano seconds here. That said, indeed, this is...

Maybe use https://play.rust-lang.org/ to take a look at the ASM and LLVM IR code. The reason might be obvious from there? > BTW, can I open a PR to add...

For the record, linking previous work here. https://github.com/quiclog/pcap2qlog

> Although I also see a `chown` in the Dockerfile that makes me dislike this approach. I am not sure we are on the same page here. The `chown` only...

Unless this is recommended by the Rust project, I would prefer not to re-export crates in our public API, for the sake of simplicity. In this particular case especially, as...

> updating this crate's version of `prost` would be a breaking change. Unless I am missing something, bumping to a breaking version of `prost` is already a breaking change for...