Max Inden
Max Inden
Agreed that this is not intuitive (i.e. a footgun). That said, I am not sure what to do about it. Cloning a metric might be expensive. Thus internally on every...
Thank you @sfleen and @cratelyn for the thorough input! Much appreciated. > It's worth noting that `Family::get_or_create()` **already performs implicit cloning** on behalf of the caller, by cloning the label...
@JayZhao in addition to djc's ask above, can you also try to reproduce the issue with the following patch applied? ``` diff diff --git a/quinn-udp/src/unix.rs b/quinn-udp/src/unix.rs index c39941d5..26fcce2d 100644 ---...
- This should be a persistent error, i.e. always happen on consecutive calls. In other words, a user can not act on the error, other than not using `quinn-udp` at...
I am assuming you are referring to the code below: https://github.com/quinn-rs/quinn/blob/8d6e48c20b71f7e915c13c33b66e2a09b6d59888/quinn-udp/src/cmsg/unix.rs#L45-L46 As far as I can tell, the cast to `msghdr_x` is fine and matches the Apple sample code: https://github.com/apple-oss-distributions/xnu/blob/8d741a5de7ff4191bf97d57b9f54c2f6d4a15585/tests/recvmsg_x_test.c#L138-L151...
Would a const counter solve your use-case? https://docs.rs/prometheus-client/latest/prometheus_client/metrics/counter/struct.ConstCounter.html
You would use the `Collector` trait to implement your own metrics collector. On a scrape of your exporter by Prometheus, `prometheus_client` would call `Collector::collect`. Your collector implementation would retrieve the...
> Getting values from the target is async right now, and `Collector`'s interface is sync, so I'd have to block... @K900 is that a problem? I assume you are running...
Hi @zakcutner, thank you for your contribution! > I've found that clearing/resetting metrics is particularly useful for testing, to avoid needing to compare each metric to the value it was...
Thanks for raising this issue @talonx. I am sorry for the inconvenience. Please keep in mind that this is a community driven project. Would you like to give this a...