Max Inden
Max Inden
Wouldn't `portreuse` and calling `listen_on` with the corresponding interface address suffice?
Thanks @imbrem for investing into rust-multiaddr performance characteristics. Can you please provide a benchmark that proves that this pull request improves performance?
> The biggest performance improvements should be in manipulating ipv4 addresses I can not think of a place where we manipulate an IPv4 address in a hot-path.
> If you want I can try to benchmark memory usage, which should be significantly improved as we eliminate the Arc allocation holding the Vec. You could test with some...
I don't use the codecov tool. Does it make sense to continue carrying it with us?
Can you expand on the rational here? While it **might** reduce compile times, I would much rather depend on a well established external crate with anything containing `unsafe` code.
Maybe @Stebalien or @lidel can help here?
> @mxinden Also, can you tell me what the binary format of `dns`, `dns4`, `dns6` and `dnsaddr` is? Is it already defined? If not, I would suggest the FQDN format...
> Are the implementations in this organization authoritive at the moment, or is it still possible to alter the binary format at this time? They are used in many production...
_Not a strong opinion. Feel free to ignore._ Appreciate being considered here as a libp2p steward. Though I don't think I should have any special permissions. That is not to...