Max Inden

First of all thanks for the detailed feature request @robo-corg. > I understand if async is out of the scope of this crate or considered an anti-feature. As a first...

> That's great to see! It looks like there is large low-level rework behind these changes, that is dropping the protobuf internal structures, am I reading that right? @lucab I...

> Hi,@mxinden .I wonder whether you are working on this proposal now, if not, I'd like to take this issue. Most of the ideas LGTM. @Yisaer I am not working...

`gauge.metrics()` will return a snapshot of the metric, `gauge.metric().set_timestamp_ms(1234));` sets the timestamp on that snapshot, not on the metric observation. Long story short, timestamp functionality is part of the data...

For the record, I wouldn't be opposed to a pull request that would add support for timestamps.

Great catch. Mind sending in a patch @keepsimple1?

Unfortunately I no longer have permissions on this repository to e.g. approve CI to run. (Not complaining, this is fine, I haven't been involved much recently :heart:.) Maybe @lucab can...

@hdost today histograms don't support [anything other than `AtomicF64`](https://github.com/tikv/rust-prometheus/blob/master/src/histogram.rs#L162), thus there is no benchmark comparing `AtomicF64` with e.g. `AtomicU64`. Benchmark running `AtomicF64` [can be found here](https://github.com/tikv/rust-prometheus/blob/master/benches/histogram.rs).

I find this use-case to be very specific and thus out of scope for this library. Of course my opinion should not be considered the final one. Instead of your...

The `Box` is needed to store multiple Collectors of different type via dynamic dispatching in the `RegistryCore`: https://github.com/tikv/rust-prometheus/blob/227a1ce83bda0fd62115e4e914fc1b4d4cfc4907/src/registry.rs#L16 > `/* do the boxing inside */` While reducing the noise of...