Max Inden

Results 900 comments of Max Inden

:+1: from my end. I won't get to it any time soon. Contributions welcome.

Thank you for the code snippets. Generally I am not opposed to moving to `hashbrown`. That said, I am not yet fully sure I understand the rational. Are you trying...

No objections to adding `Registry::with_prefix_and_labels`. Contribution welcome.

Closing here given the concerns above. Please open a new pull request in case you want to continue the discussion.

Thanks for writing this out. Never thought there would be the need for more than one label. Happy to accept a contribution @popadi. Off the top of my head, what...

See also https://github.com/prometheus/client_rust/issues/52.

> and are definitely not fully compatible with each other. Can you expand in which way recent Prometheus versions are not compatible with the OpenMetrics specification? Note that this has...

@08d2 and @kalabukdima I understand your concerns. @richih do you have additional input here as one of the authors of the open metrics specification? How should the Rust client proceed...

> FYI, OpenMetrics is now part of Prometheus officially Can you point us to some docs @richih? Is OpenMetrics the default? Is setting the HTTP content type still needed? Related:...

Do I understand correctly, that this would generate the metric registration logic? I am not opposed to adding this to this crate. That said, given that it would be a...