Max Inden
Max Inden
Duplicate of https://github.com/libp2p/rust-libp2p/issues/3262.
> The number of protocols is technically unbounded and could thus lead to a cardinality explosion. I argue that the number of locally supported protocols is likely bounded. Thus, whenever...
Thank you for the research @jakubDoka! > The most significant hot spot though is something different. [here](https://github.com/libp2p/rust-libp2p/blob/b7914e407da34c99fb76dcc300b3d44b9af97fac/swarm/src/connection.rs#L434) we unconditionally create `Arc` for each available protocol as the last thing before...
@nazar-pc can you resolve the merge conflicts?
Thank you for documenting this. Unfortunate that we did not catch this earlier. Two alternative suggestions: 1. Only allow denying a pending connection, not an established connection. In other words...
> I am still of the same opinion that I think we should design `RecordStore` to: > > * Implement `Clone` > > * Return `Future`s that don't have lifetimes...
> As an aside once you get enough records it can become more efficient to invert the republish logic. The current implementation iterates through each record and contacts the closest...
If I am not mistaken, this would play nicely with your idea of splitting up the `UpgradeXXXbound` traits, right @thomaseizinger?
> I believe `Autonat` should start firing `ToSwarm::ExternalAddrExpired` to do proper cleanup and close the loop here. Yes, good catch! Out of curiosity, why is your node continuously changing its...
What would be the benefit of being more strict? When in doubt, I suggest following the _Robustness Principle_: > "Be conservative in what you do, be liberal in what you...