Pablo Baeyens
Pablo Baeyens
Since we discussed this on the Collector stability meeting and the new test was not deemed strictly necessary to merge this PR I am going to merge it without the...
Sure, Damien assigned it to you :) Please start small so we can give you feedback without you investing too much effort
I think we would need to have some tooling if we are going to do this, otherwise the lists would go out of sync very quickly
I am in favor of 1 as well
@open-telemetry/collector-approvers does (1) look good to you?
Looking at https://github.com/open-telemetry/community/blob/main/assets.md#opentelemetry-bot it may be hard to do (1) given that this is an OpenTelemetry-wide token. So we may want to look into an alternative solution
Would it improve things if we base things on the PR title/description? e.g. something like "if there is a PR that has a name with this thing in it and...
> The only issue I see with this is that we need to make sure release managers only ever use the bot to create the PR, but there's only one...
``` --- FAIL: TestUnmarshalConfigOnlyHTTPEmptyMap (0.00s) /home/pablo.baeyens/Source/otel/opentelemetry-collector/receiver/otlpreceiver/config_test.go:82: Error Trace: /home/pablo.baeyens/Source/otel/opentelemetry-collector/receiver/otlpreceiver/config_test.go:82 Error: Not equal: expected: configoptional.Optional[go.opentelemetry.io/collector/config/configgrpc.ServerConfig]{hasValue:false, value:configgrpc.ServerConfig{NetAddr:confignet.AddrConfig{Endpoint:"", Transport:"", DialerConfig:confignet.DialerConfig{Timeout:0, _:struct {}{}}, _:struct {}{}}, TLSSetting:(*configtls.ServerConfig)(nil), MaxRecvMsgSizeMiB:0, MaxConcurrentStreams:0x0, ReadBufferSize:0, WriteBufferSize:0, Keepalive:(*configgrpc.KeepaliveServerConfig)(nil), Auth:(*configauth.Config)(nil), IncludeMetadata:false, Middlewares:[]configmiddleware.Config(nil),...