Results 781 comments of Pablo Baeyens

> Is this about adding documentation for people creating new components (ie, writing Go code that ends up in a distribution), or is it for end-users, configuring components available in...

@hickeyma I think having a link to that doc is definitely better than not having anything! The benefit of having a testable example is that we ensure that the examples...

I took a look at your PRs @hickeyma, they make sense to me :) > Does this work when its not an end to end example for a user? I...

> I am wondering if providing a testable example which is not end to end would make sense for the components? Ah, okay, thanks for clarifying! I think there is...

It looks like this needs a bigger refactor than what I originally thought :( We need to pass the logger to be able to log this warning, but for that...

This is the best I could come up with, although it comes with a lot of plumbing. The logger is not available when loading the configuration, so we need to...

Asked on #5615 for more people to participate in the discussion.

I think we should fail fast instead of logging a warning. This is a breaking change, but I think it's worth it in terms of improved troubleshooting and we can...

> failing to start up when an unknown config key is present which may catch typos in some cases We already do this by default, so it makes all the...

I started making a PoC for raising a warning (and failing if enabled through a feature gate) on #5734. Since the logger is not available when loading the configuration, we...