Pablo Baeyens
Pablo Baeyens
Requesting review from the reviewers on #10069
> . While conceptually I think it is nice, to an end-user this changes nothing. I am concerned about the amount of time we'll spend dealing with this breaking change...
Can you fix CI? After that I am happy to merge this
@open-telemetry/collector-approvers planning to merge this tomorrow if nobody blocks before then
@codeboten Right, I forgot about this. I don't see us changing `mapstructure` tags for something else but it makes sense to discuss explicitly. Should we file an issue about this?...
We had some discussion about bumping `MinTLS` to 1.3. I think this is something that is not a breaking change given that the Go team themselves have proposed changes of...
I think we are good to merge this once @mwear takes another look :)
I think this is no longer blocked, right?
``` # github.com/open-telemetry/otel-arrow/collector/netstats Error: /home/runner/go/pkg/mod/github.com/open-telemetry/otel-arrow/[email protected]/netstats/netstats.go:138:51: undefined: exporter.CreateSettings Error: /home/runner/go/pkg/mod/github.com/open-telemetry/otel-arrow/[email protected]/netstats/netstats.go:173:51: undefined: receiver.CreateSettings ```
Closing this since it was meant just as a PoC