Pablo Baeyens
Pablo Baeyens
:thinking: Another error ``` --- FAIL: TestGenerateAndCompile (74.27s) --- FAIL: TestGenerateAndCompile/No_Dir_Permissions (2.51s) main_test.go:441: Error Trace: D:/a/opentelemetry-collector/opentelemetry-collector/cmd/builder/internal/builder/main_test.go:441 Error: An error is expected but got nil. Test: TestGenerateAndCompile/No_Dir_Permissions ```
:tada: :tada:
> It's a limitation of pkg.go.dev that I don't think we can do much about. Splitting into multiple packages would definitely help, but that would be for the next major...
I unpinned this one temporarily to pin #33896. I will revert this change in two weeks if we don't get more comments on that issue.
> I don't know if I like the idea of making it a separate package. It would only have a single consumer, with no real prospects of having more in...
@donald-cheung Let me know when you have approval from your org and want to reopen the PR and I can do it for you :)
@donald-cheung Sorry, I somehow missed this, it looks like Curtis helped you reopen the PR :)
@donald-cheung This is because of the toolchain directive https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/c25c058422e0874a1868285e9658218a1f4ddbf2/cmd/otelcontribcol/go.mod#L7 Your local go version does not match that of CI. That's fine but you need to revert the change on the...
@pavolloffay @MovieStoreGuy PTAL!
@MovieStoreGuy Could we get this merged if ready?