Michał Wawrzyniec Urbańczyk
Michał Wawrzyniec Urbańczyk
To answer the questions from the OP: * I am supportive of "no space after * and &" change * if we are to either have all namespaces indented or...
@JaroslavTulach > [Formatting CI check](https://github.com/enso-org/enso/runs/7967611255) seems to be using GraalVM 21.3 instead of 22.1. Ccing @mwu-tow ... The workflow has [hardcoded GraalVM version](https://github.com/enso-org/enso/blob/develop/.github/workflows/formatting.yml#L11), it needs to be bumped as well....
I have missed this functionality for quite a while. I'm looking forward for this to be merged and delivered! Many thank @Kobzol for implementing this!
> Was the verify benchmarks check started at all after https://github.com/enso-org/enso/commit/e4f2769cd82f3f7f97562a8c9ac94ae5ff87d648? Where can I find it among the checks? No, the workflow was removed. I ended up integrating the check...
Benchmarks are being run with `-Dbench.compileOnly=true` under `backend ci-check` command (which is what Engine CI does). This makes most sense to me: that job already did build benchmarks and executing...
@MichaelMauderer TBH I'm confused here. PR was ready to merge, apart from waiting review by Wojciech and next release bump. However, it seems that #1726 actually duplicated parts of it,...
@JaroslavTulach Interesting that it fails only for the parser binary. I will investigate this.
> > @JaroslavTulach Interesting that it fails only for the parser binary. > > For what other reason should it fail? Parser binary is the only `.so` file we produce....
It seems that the parser can be built with the statically linked `musl` using the following: ```sh rustup target add x86_64-unknown-linux-musl RUSTFLAGS="-C target-feature=-crt-static" cargo build -p enso-parser-jni --target=x86_64-unknown-linux-musl ``` @JaroslavTulach...
> On the backend the change has been merged. @mwu-tow do you want to add those flags to regular CI build? The native parser binary is built only by the...