ide
ide copied to clipboard
API update to support the newly added reexport field.
Pull Request Description
IDE support for https://github.com/enso-org/enso/pull/1793
Important Notes
This PR is based on Adam's API updated, as they are necessary for newer engine versions. Will refrain from testing scenarios until "actual" merge is possible. New field is not actually "used" (as in leading to visible user change), this PR only introduces API support.
Checklist
Please include the following checklist in your PR:
~- [ ] The CHANGELOG.md
was updated with the changes introduced in this PR. ~
- [x] The documentation has been updated if necessary.
- [x] All code conforms to the Rust style guide.
- [x] All code has automatic tests where possible. ~- [ ] All code has been profiled where possible.~
- [x] All code has been manually tested in the IDE. ~- [ ] All code has been manually tested in the "debug/interface" scene.~
- [ ] All code has been manually tested by the PR owner against our test scenarios.
- [ ] All code has been manually tested by at least one reviewer against our test scenarios.
The logic behind the re-export naming is that every module implicitly exports all its definitions. Another module can re-export symbols that were defined in a different module. In other words, module B takes the symbol exported from module A and re-exports this symbol with a new module name.
So, this re prefix only tells that this module is not the one where the symbol was defined.
So, this re prefix only tells that this module is not the one where the symbol was defined.
Ok, so in case when no module re-export given symbol, the reexport
field will be empty and we ought to make import basing on the module
field, right?
@mwu-tow What is the status of this PR? Should it be updated/finished, or is it abandoned and should be closed?
@MichaelMauderer TBH I'm confused here. PR was ready to merge, apart from waiting review by Wojciech and next release bump. However, it seems that #1726 actually duplicated parts of it, so now it is just mess.
Likely the missing pieces should be manually merged back.
@MichaelMauderer TBH I'm confused here. PR was ready to merge, apart from waiting review by Wojciech and next release bump. However, it seems that #1726 actually duplicated parts of it, so now it is just mess.
Likely the missing pieces should be manually merged back.
This PR must have fallen through the cracks during the release process back then.
Can you bring this PR up to date or create a new PR with the things that still need to be merged? (After checking with planning about priorities)