Mateusz Woś
Mateusz Woś
Thanks for your contribution @EVODelavega! Unfortunately, I won't be able to accept and merge your PR. Decimal is aiming to be a dependency-free library and by adding this feature we...
Hi! Right now this library does not expose any method that could return fractional part immediately (nither as `Decimal`, nor as `big.Int`), but such thing can be done using `decimal.Mod`....
HI @aping. Thanks for spotting this issue. I will take a closer look at that. `decimal` is mainly focusing on correctness rather than speed, but I agree that something that...
I analyzed this issue and I was not able to come up with a solution. `math/big` standard library that we use underneath is a bottleneck here, so fixing this issue...
Probably former developers of `decimal` weren't aware of the limitations of the `math/big` library back then and `int32` sounded like good middle ground. Are there other `decimal` methods that perform...
Thanks! :D I will test other decimal methods myself then. For now, setting the upper boundary for exponents is the only reasonable workaround for using Float64, sadly. If I come...
I see your implementation is failing on negative cases (`-7.5 mod 2` and `-7.5 mod -2`. Mod implementation should return 0.5 and -1.5. (current implementation was incorrectly calculating `-7.5 mod...
Hi @icetech233! Have you tried struct tagging? It should work fine. Please take a look at this article: https://www.digitalocean.com/community/tutorials/how-to-use-struct-tags-in-go
The implementation overall looks good. If you can @ldcicconi, please rebase it so I can merge it to master and add unit tests for this implementation. If you don't have...
Hmm, I'm not sure why this algorithm is failing on numbers in the range (0, 1). What method you have used for calculating sqrt? Can you point me to the...