Mateusz Woś comments

Results 132 comments of


                                            Mateusz Woś

mod bug fix

Hi! Could you provide new tests for your change? Current ones were not enough to cover edge cases.

How to convert a string to NullDecimal?

Thanks for explaining this @edbond

Zero should not be exposed to the public

It's debatable, but probably you are right. At least such constant/variable should not be used in any of decimal methods. Currently, I see a single usage of this const in...

Zero should not be exposed to the public

Thanks for explaining how it looks like in the std lib Rick! :) Now I wonder what would be the best idea here, as at one point this library would...

[FEAT]: add support to official mongo providers and legacy mgo?

Hi @quenbyako. The only reason why we have not accepted any previous community implementations was the fact they included external dependencies, and we want to keep this library dependency-free. Also,...

extend readme to highlight special cases around parsing and printing when using trailing zeros

Thanks for your contribution @dreamerjackson and sorry for such a late reply. Could we wait a bit, so the author of https://github.com/shopspring/decimal/pull/296 could reply to my comments? This PR may...

fix roundCeil,roundFloor,roundUp and roundDown examples

Sorry for the late response @richardJiang :// There were at least 4 PRs that fixed `Round*` documentation and I was not aware your were the first one that did it,...

decimal.Pow result fail

I've finally implemented an improved `Pow` method. Please take a look at this comment: https://github.com/shopspring/decimal/issues/55#issuecomment-2033204145

Pow doesn't work for decimal exponents

Hi all! I apologize it took me so long, but finally, I improved the `Pow` operation. Now it correctly calculates power operation for all decimals. In addition to that I've...

Pow doesn't work for decimal exponents

We released 1.4.0 a moment ago. You can now try a new `Pow` implementation :D