Mats Wichmann comments

Results 559 comments of


                                            Mats Wichmann

Adding C# support

CheckPython and CheckPythonHeaders

Does this fill a distinctly different need than `EnsurePythonVersion`?

multi-threaded (-j N) scons does not serialize builder output

Obviously, this topic has come up a number of times before. SCons doesn't normally capture any of the output from the external commands it passes off work to, but it...

multi-threaded (-j N) scons does not serialize builder output

Any PR in this area would want to first ratchet forward the intended platform module refactor to use modern interfaces, and then build off that. `subprocess.run` is a simple interface...

MSVC: Extend the msvc cache key due to potential issues with the external cache file consistency

> The ninja iterative_speedup test seems to be failing sporadically in the windows-2022/windows-latest environment. > @mwichmann Any thoughts? Yes - I think it's pretty useless as a mandatory test. It's...

MSVC: Extend the msvc cache key due to potential issues with the external cache file consistency

that's funky, but why would if fail for both GitHub-WIndows and for Appveyor (one image only)....???

--debug=explain doesn't tell you everything that changed

Such a change seems to work. On a simple testcase, I get: ``` scons: rebuilding `build/bugs.o' because: `src/bugs.cpp' changed the contents of the build action changed action: $CXX -o $TARGET...

scons incorrectly parses targets when command line options are used for variant_dir

This is also the reason options with nargs > 1 are not working. scons is mangling the arguments in some way before we get here, so it's likely most of...

scons incorrectly parses targets when command line options are used for variant_dir

Okay, looks to me like the problem is actually here - `SConsOptions.py`, `SConsOptionParser._process_long_opt`: this method overrides the one from base `OptionParser` by adding this: ```python try: opt = self._match_long_opt(opt) except...

--interactive does not clean cache signatures

I tried this, it works as noted if you don't leave scons, while if you do leave scons if behaves as expected (that is, rebuilds again).