scons icon indicating copy to clipboard operation
scons copied to clipboard

--debug=explain doesn't tell you everything that changed

Open bdbaddog opened this issue 7 years ago • 2 comments

This issue was originally created at: 2015-03-02 00:59:53. This issue was reported by: thosrtanner.

thosrtanner said at 2015-03-02 00:59:53

Basically, if you run scons --debug==explain and both dependencies and build command has changed, you only get told about the dependencies. This seems an unnecessary suppression.

Could easily do this by taking the if len(line) == 0 out at around line 1241 (and it'd probably make sense to shove fmt_with_title into the subsequent if).

bdbaddog avatar Jan 02 '18 15:01 bdbaddog

Such a change seems to work. On a simple testcase, I get:

scons: rebuilding `build/bugs.o' because:
           `src/bugs.cpp' changed
           the contents of the build action changed
               action: $CXX -o $TARGET -c $CXXFLAGS $CCFLAGS $_CCCOMCOM $SOURCES
g++ -o build/bugs.o -c src/bugs.cpp
scons: done building targets.

In this example, the contents of CCFLAGS changed. I have other changes pending for explain, should I include this one?

mwichmann avatar Dec 09 '18 19:12 mwichmann

Yes.

bdbaddog avatar Dec 09 '18 19:12 bdbaddog