Michel Weststrate
Michel Weststrate
would you mind adding a unit test to demonstrate the problem solved by this change?
Interested in attempting a PR?
Really awesome! Thanks for doing this :). Looks really promising, just up front a notif that it will probably take me a while to review 😅
Looks reasonable! Could you include a unit test demonstrating the original problem, and demonstrating that in the end the data is still getting frozen?
Thanks for PR the test. Would you mind adding the other test case in your report as well, as I'd expect this PR to fail without fix :)
@chrissantamaria yeah it'd be great to add that one as well. I had expected this branch to fail, but it seems the CI didn't run at all in the first...
Preferably map-set, base is a bit overcrowded :-P. Well, I guess we have to migrate to GH actions finally.
> Done - wasn't quite sure how to differentiate those tests in the naming so feel free to edit Looking good! > Happy to take a look at GH Actions...
I think that analysis is correct, it could detect the same value is assigned and keep the result. Feel free to attempt a PR
Sorry that is a bit too much code to understand to see why or why not your project is working and the error thrown in the test is not the...