immer icon indicating copy to clipboard operation
immer copied to clipboard

Published 20 hours ago • verified publisher icon immerjs

fix: special case NaN in setter

Open Rayzhangzhang opened this issue 3 years ago • 3 comments

I suppose there is a bug in setter about ‘NaN’ special case.

Rayzhangzhang avatar Feb 26 '22 12:02 Rayzhangzhang

✔️ Deploy Preview for quizzical-lovelace-dcbd6a canceled.

🔨 Explore the source changes: a2b171758bc6e23010d39897583e0f80a427433f

🔍 Inspect the deploy log: https://app.netlify.com/sites/quizzical-lovelace-dcbd6a/deploys/622db8ed8c9b5e00084783d2

netlify[bot] avatar Feb 26 '22 12:02 netlify[bot]

would you mind adding a unit test to demonstrate the problem solved by this change?

mweststrate avatar Mar 05 '22 16:03 mweststrate

would you mind adding a unit test to demonstrate the problem solved by this change?

Thanks for replay, the unit test has been added.

Rayzhangzhang avatar Mar 13 '22 09:03 Rayzhangzhang

Hi, @Rayzhangzhang, @mweststrate, this PR cause 8 test failures. thx

unional avatar Oct 30 '22 20:10 unional

:tada: This PR is included in version 9.0.17 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Jan 02 '23 11:01 github-actions[bot]