Michel Weststrate
Michel Weststrate
Some way of marking exceptions as handled would be great. I have currently a hard time of testing exceptions thrown by components or error boundaries themselves. Although I can assert...
@thysultan no, as `fn` won't throw the exception synchronously > They’re not meant to be used for control flow. You don’t want somebody to introduce a bug to a leaf...
See the test: https://github.com/mweststrate/react-error-boundaries-issue/blob/master/index.js#L23 Real browser/ DOM rendering / nested components / no test utils / no enzyme
Yeah these kind of subtle differences are exactly the reason why I prefer to have (part of) the test suite running in the DOM :). There are subtle differences in...
Looking good, thanks for the rename as well!
That looks correct! Would you mind adding a unit test to protect against regressions?
Merged! Thanks again, and apologies for the late follow up.
Feel free to create a plugin that supports these data types, similar to how Map / Set is supported. Or it might be sufficient to widen the array detection in...
Your test creates a non-unidirectional graph, which isn't supported by Immer. There should be only one single path from any node in your tree to the root. After the first...
Makes sense! PR welcome