Marin Veršić

Build `config/swarm/executor.wasm` in CI

18

Currently, every developer builds executor on his own machine and commits it into git. Then this executor is used in tests. This creates too many unnecessary git conflicts and prevents...

depending on the previously received control flow messages, is it possible that some of the `BlockMessage`s should just be rejected? _Originally posted by @mversic in https://github.com/hyperledger/iroha/pull/4115#discussion_r1449877651_

I don't understand when it should be done. Consider adding description or create an issue _Originally posted by @Arjentix in https://github.com/hyperledger/iroha/pull/3621#discussion_r1272696671_

As a slight recommendation, o'd wager this doesn't need to be represented as a string, but rather there ought to be an enum for this _Originally posted by @appetrosyan in...

Bitmap masks

1

```json "AccountEventSet": { "Bitmap": { "repr": "u32", "masks": [ { "name": "AnyAsset", "mask": 1 }, { "name": "Created", "mask": 2 }, { "name": "Deleted", "mask": 4 }, ``` Why don't...

Bitmap repr field in schema

1

```json "AccountEventSet": { "Bitmap": { "repr": "u32", ``` I don't think that unsigned vs signed conveys meaningful information for a bitmap, rather it should be `"repr": 32`

Custom ISI/expressions in executor

1

I'd like if we could make one integration test that covers this use case. ### Rationale Previously we had expression system but we removed it for the sake of simplicity...

in `Config::load` every early exit with `?` will produce this error because `Config` is dropped. It can be most easily reproduced if you send into `Config::load` name of a file...

Trigger execution order

2

Maybe this is a non-issue, but we should define what the order of execution of triggers is when multiple triggers are triggered at the end of block. Also, impose ordering...

Improve transactions submitting API in Client

1

check [here](https://github.com/hyperledger/iroha/pull/3485#discussion_r1216872211) for suggestions