Marin Veršić

Immutable configuration

4

I would prefer config to have private fields with constructors and getters for the following reasons: 1. consistency - access to some fields has to be done through getters because...

Look into `TransactionBuilder::set_ttl`. This might be API breaking change

Consensus should continue working in the presense of heavy transactions

11

Invalid transactions take a lot of time to process. This is probably because they require cloning of `wsv`. When there is a batch of invalid transactions in a block the...

Remove predictable ordering hack from sumeragi

1

This was introduced in #4263 to prevent consensus from operating if there is a bug in the implementation. We should make sure that consensus operation is well covered with tests...

why would you do this? _Originally posted by @mversic in https://github.com/hyperledger/iroha/pull/4181#discussion_r1465216449_

Is it necessary to return algorithm here, isn't it a known fact which algorithm is used in `p2p` crate? _Originally posted by @mversic in https://github.com/hyperledger/iroha/pull/4181#discussion_r1469344793_

Genesis is signed with correct key

1

When genesis is received via listen for genesis via `sumeragi_listen_for_genesis`(`BlockCreated`/`BlockSyncUpdate`) it is not verified that genesis is signed with `IROHA_GENESIS_PUBLIC_KEY`. Not even leader that creates the genesis block verifies that...

Define a set of default permission tokens

7

Let's see what should be the default set of permissions and what should their names be. Currently we have (as listed in `smart_contract/executor/src/default/tokens.rs`): ``` CanUnregisterAnyPeer, CanUnregisterDomain, CanSetKeyValueInDomain, CanRemoveKeyValueInDomain, CanRegisterAccountInDomain, CanRegisterAssetDefinitionInDomain,...

Remove address from `PeerId`

1

I propose that we move `PeerId::address` into `Peer` struct

Remove address from `commit_topology`, keep public key

1

Reasons: 1. Peers are uniquely identified only with a public key 2. it's hard to replay blocks in a new environment 3. reduces chain size of blocks