iroha icon indicating copy to clipboard operation
iroha copied to clipboard

Remove predictable ordering hack from sumeragi

Open mversic opened this issue 1 year ago • 1 comments

This was introduced in #4263 to prevent consensus from operating if there is a bug in the implementation. We should make sure that consensus operation is well covered with tests and remove this backdoor

mversic avatar Feb 07 '24 11:02 mversic

Going to be removed in #4518

Erigara avatar May 31 '24 08:05 Erigara

I see in the code that that hack has been removed and it looks like iroha has been running successfully without it. But I can't understand if the sorting of peers has become unpredictable, which seems to be the main problem why this task was opened.

AlexStroke avatar Jul 10 '24 14:07 AlexStroke

this is ok, we can close it

mversic avatar Jul 10 '24 19:07 mversic