Marin Veršić

Rename `JsonString` to `JsonValue`

1

although it's serialized as a string when serializing to SCALE, it's an implementation detail how json is stored in memory.

`CommittedTransaction::error` is not part of the block hash

4

Since `CommittedTransaction::error` is not protected by the block hash why keep it in the block? Every block replays all transactions and determines whether transaction is correct or faulty If we...

Currently we only provide latest block height, but I don't think it would cost us much to provide the whole header. If that is too costly or deemed unnecessary, I'd...

Allow `EventFilterBox::TriggerCompleted` as a trigger filter

3

I still not sure why we should treat trigger completion event separately. It was requested like that in #2885, but reasons are not specified. _Originally posted by @Erigara in https://github.com/hyperledger/iroha/pull/4866#pullrequestreview-2191212630_

This test seems to fail spuriously: ``` ---- encryption::chacha20poly1305::tests::decrypt_should_fail stdout ---- thread 'encryption::chacha20poly1305::tests::decrypt_should_fail' panicked at crypto/src/encryption/chacha20poly1305.rs:111:48: called `Result::unwrap_err()` on an `Ok` value: [72, 101, 108, 108, 111, 32, 97, 110,...

Ergonomic MST

3

Ideas on how can we make MST more ergonomic: 1. All smart contracts for MST should be registered from Executor, i.e. be put in default executor migration 2. I think...

Record trigger execution as a transaction

2

Financial applications need to track the flow of assets. It has been noted that trigger execution isn't transactional. If a trigger is invoked and it transfers asset from user A...

`NumericSpec` and operations on numeric

3

I think it's better to remove the validation and mention in the docs that mul and div can cause the numeric spec to change, and that users need to do...

Why is query store saved to the disk as part the snapshot functionality? When deserializing snapshot from the disk the query store should just be created as empty

Trigger execution model

2

Current execution model is this: 1) isi produce events (including ExecuteTrigger event) 2) triggers are matched against events and put into the queue for later execution 3) after block commit...