Michiel Van Beirendonck
Michiel Van Beirendonck
Think I found another issue with noise estimation that's so small that I won't create a seperate ticket. In `estimate_pbs_noise`: https://github.com/zama-ai/concrete/blob/ae0bef18e85fdbc96c0c3580ca8253e0d0cc66ac/concrete-npe/src/operators.rs#L712 I believe this should be changed to: ```rust let...
Hi @aPere3, Thanks for your reply! Next time I'll remember to just create two separate tickets 😉 I would also be interested in other ways to measure and verify the...
Thanks for providing some guidance! I already played around a bit with your suggestion in the past week. On our side, it actually looks most interesting to have `FixedPoint` as...
Thanks for the quick reply! I agree that `fixedpoint` should not be a submodule here. I took the submodule approach as in https://github.com/ucb-bar/dsptools to get a quick proof-of-concept that everything...
> As an alternative to depending on a published version of the fixed point library, we could also investigate what it would take to change `chiseltest` in such a way...
> > I had to also copy over `Utils` as it is a private object. > > I think we will be able to make that more public, such that...
On another note, in a project of mine, we created some extensions to `chiseltest` that allow things like peeking a `Vec[Vec[UInt]]` with a `Seq[Seq[BigInt]]` in a generic way using typeclasses....
> @mvanbeirendonck Do you want to make a PR with the changes that we discussed above? Any way I can help? Yes! I need to find some time to give...
Update: I forgot the `joinAndStep(dut.clock)`. The `fork.withRegion` was not fixing anything; it just ensured the testbench finished without executing the `expect` calls. I have also found the actual issue. I...
I'm putting a note link here to https://github.com/chipsalliance/chisel/issues/3161. It looks advantageous to tackle these two issues together.