Maxim Vafin

Results 51 comments of Maxim Vafin

> You mean insted of `{"aten::dot", op::translate_dot}`? I mean `{"aten::dot", op::translate_1to1_match_2_inputs}` so you do not need to create translate_dot since there is a generic helper that can do same

> RuntimeError: dot : expected both vectors to have same dtype, but found Float and Long Yes, this error is printed by torch, so you do not need to support...

@LucaTamSapienza, yes, please also add tests for `out`, but since `translate_1to1_match_2_inputs` doen't support `out`, please use your function `translate_dot` and reuse `translate_1to1_match_2_inputs` inside of it.

@rghvsh Could you at least verify that your code builds and passes your tests before asking for next review iteration?

Tests fail with ``` @pytest.mark.parametrize("use_out", [False, True]) def test_atan2_with_out(self, dtype1, dtype2, use_out, y, x, ie_device, precision, ir_version): self._test( > *self.create_model(dtype=dtype, use_out=use_out), ie_device, precision, ir_version, kwargs_to_prepare_input={"y": y, "x": x} ) E...

Still same error: ``` def test_atan2_with_out(self, dtype1, dtype2, use_out, y, x, ie_device, precision, ir_version): self._test( > *self.create_model(dtype=dtype1, use_out=use_out), ie_device, precision, ir_version, kwargs_to_prepare_input={"y": y, "x": x} ) E TypeError: TestAtan2.create_model() got...

Also you have build issues. Please make sure your code builds

> > Also you have build issues. Please make sure your code builds > > Can you please explain this briefly or any document suggestions about this issue? You need...