[PT FE] Add aten::atan2

[rghvsh]

Details:

• Adds aten::atan2 operator

Tickets:

• Closes #20575

[rghvsh]

Hey @mvafin! I wrote this code for tffe this was a first draft will work on this

[rghvsh]

Hi! @mvafin made some changes is this better?

Thanks Raghav

[rghvsh]

Hey @mvafin made the recommended changes please review once.

[rghvsh]

Hi! @mvafin and @mmikolajcz Thank you for the review will make the changes

[rghvsh]

Hi! @mvafin and mmikolajcz made changes to the test and translation please check.

Thanks Raghav

[mlukasze]

hey @rghvsh while you are waiting for next round of the review, could you please fix at least clang check? and take a look for rest of red ones (they may be, but may be not something you should correct as well)

[mlukasze]

@mvafin & @mmikolajcz I would like to ask to finalize this PR with our contributor. It took some time and effort, it's worth to have it for upcoming release.

[mvafin]

@rghvsh Could you at least verify that your code builds and passes your tests before asking for next review iteration?

[mlukasze]

@mmikolajcz & @mvafin please retake a review

[rghvsh]

Hi! @mvafin @mmikolajcz I think i've fixed build issues and added test for different types in x and y. I had some questions: As there is optional_out decorator I don't need to use mutate_input or apply the if block and return result straight away? How to fix the get inputs with promoted types?

PS: the CI tests are failing with no error logs, Thanks, Raghav

[rghvsh]

Hi @mvafin @mmikolajcz! Made the changes. Last time for the CI I guess the cmake did not configure properly.

[rghvsh]

Hi @mvafin @mmikolajcz! Made the changes

[mlukasze]

build_jenkins

[mvafin]

Tests fail with

    @pytest.mark.parametrize("use_out", [False, True])
    def test_atan2_with_out(self, dtype1, dtype2, use_out, y, x, ie_device, precision, ir_version):
        self._test(
>           *self.create_model(dtype=dtype, use_out=use_out),
            ie_device,
            precision,
            ir_version,
            kwargs_to_prepare_input={"y": y, "x": x}
        )
E       NameError: name 'dtype' is not defined

[mvafin]

Still same error:

    def test_atan2_with_out(self, dtype1, dtype2, use_out, y, x, ie_device, precision, ir_version):
        self._test(
>           *self.create_model(dtype=dtype1, use_out=use_out),
            ie_device,
            precision,
            ir_version,
            kwargs_to_prepare_input={"y": y, "x": x}
        )
E       TypeError: TestAtan2.create_model() got an unexpected keyword argument 'dtype'

[github-actions[bot]]

This PR will be closed in a week because of 2 weeks of no activity.

[mlukasze]

hey @rghvsh will you find a time to address Maxim's requests?

[github-actions[bot]]

This PR will be closed in a week because of 2 weeks of no activity.

[github-actions[bot]]

This PR was closed because it has been stalled for 2 week with no activity.