muvaffak
muvaffak
Quoting my message from Slack. This was a long discussion when we first discussed how to do observe-only resources, i.e. whether it should be an annotation/policy field or a separate...
@negz this issue causes `Creating` condition to never appear in status, which makes it feel like there isn't any progress.
FYI, this causes reconciler to drop any status update made in `Observe` before the first successful `Create` call. In long-running creation calls, like AWS [DBs](https://github.com/crossplane/provider-aws/blob/4339c3ad8eccf12be76e10111e09dc576d6f3ac8/pkg/clients/rds/rds.go#L341), Azure [DBs](https://github.com/crossplane/provider-azure/blob/master/pkg/controller/database/postgresqlserver/managed.go#L130) and async [Terrajet...
> If during Observe we update the MR status then return ResourceExists: true The case I'm referring to is where we have to return `ResourceExists: false` because creation actually failed...
@negz We do that in Terrajet in [this line](https://github.com/crossplane-contrib/terrajet/blob/36c9793/pkg/controller/external.go#L134) to trigger a new creation, [here](https://github.com/crossplane/provider-azure/blob/9067597/pkg/controller/database/postgresqlserver/managed.go#L116) in Azure PostgreSQL. In fact, I think it can be considered a bug if we...
@negz Opened https://github.com/crossplane/crossplane-runtime/issues/307 to be more specific about the problem I mentioned above. We can keep this issue contained to status updates being omitted after `ExternalClient.Create`.
cc @prasek @negz @hasheddan
See https://github.com/crossplaneio/stack-gcp/issues/157 . I think it's a valid use case for keeping the database while apps come and go, which is something `reclaimPolicy: Recycle` can enable.
@salaboy are you still interested in making this PR ready to merge?
Taking: * acm.Certificate * cache.CacheCluster * cache.ReplicationGroup * cloudfront.Distribution * ecr.RepositoryPolicy * iam.OpenIDConnectProvider * lambda.Function * notification.SNSTopic * rds.GlobalCluster * redshift.Cluster I've scanned all missing ones in `examples` folder. The...