Frederik Gartenmeister
Frederik Gartenmeister
What is the state of this?
Yes, I would say so.
@lemunozm either I did something wrong or https://github.com/centrifuge/centrifuge-chain/pull/1812/commits/7b4ab7499973e834c70cd3ddddb75b8f7f922b73 proofs that the implementation of `IntoSeconds` for `Millis` does not provide us with type safety. I think we should make them new...
@lemunozm I am not sure if I implemented it wrongly, but I can not figure out how to fix the test. ^^
for me for the migration: https://github.com/centrifuge/centrifuge-chain/pull/1739/files#diff-637356fbd7809c17265d6b8ab519abc2b0ffa4df672cfb33a321795190f441baR580
@lemunozm in order to allow the UI and the indexers to use that feature, while we are still unsure if we want to ship it with the given inconsistency we...
Yes, but atm we mostly have non interest bearing assets.
Although I am not convinced that `orml-parameters` is the best idea to be used. We could still extend `pallet-fees` IMO and have a better event resolution.
@lemunozm not sure if this is already covered. We needed that feature in production and I wasn't sure if the chain supports it. So I wrote the test to verify....
Nah, this line https://github.com/centrifuge/centrifuge-chain/blob/430fbe9df5ccd51936535bce3362c20818034fc1/pallets/loans/src/tests/repay_loan.rs#L553 should provide a lower price than the one provided by the repayment input.