Frederik Gartenmeister

Results 120 comments of Frederik Gartenmeister

With which rust version are you compiling @wpank? Have not built it in a while but this one should work `nightly-2020-08-16`.

Needs acceptance from parity in cumulus

> I would suggest removing the ability to burn/transfer an item for the collection's admin. This means if I own an item, then no one could take it from me,...

Isn't it a bit confusing to have it refer to itself? What is the advantage here over extending the `trait LocakableNonfungible` with `fn is_locked()` and implementing this on NFTs. Feels...

Anyways, don't want to criticize the design here. My main reasoning here is to solve the behaviour of uniques/nfts with respect to ensuring locked/owned nfts are not removed by destroying...

@jsidorenko that looks great! Thanks for adapting so quickly. One question: * Why is this `B0-silent` although it contains `E0-runtime_migration`?

@xlc @joepetrowski @jak-pan @girazoki WDYT about the converter like this? Happy to adapt to what is the compromise everybody is happy with.

Also @KiChjang do you already have some remarks?

You mean as part of the resulting [u8; 32]? I am not sure this adds a lot, but I am also not against it. * Security is already derived from...

@xlc I thought about adding a fixed prefix to the resulting `[u8; 32]` and my main thoughts against it are * a short prefix (e.g. `*b"P1000"`) → higher probability to...