Frederik Gartenmeister

Results 120 comments of Frederik Gartenmeister

Close in favor of https://github.com/centrifuge/centrifuge-chain/pull/1812/commits/fcddabf7f6eabde24ac2d0b89b7863ff4d06e06d

No opinion here from my side 😃

`cfg-primitives` are mostly primitives that are really specific to us. Mostly, all teams use the same setup -- e.g. `type Balance = u128` but no trait or pallet should depend...

So `cfg-traits` MUST NOT contain any types from `cfg-types`?

Do we need this for something specific or is this just an improvement?

I actually like that grouping. I think it makes the error reading in code at least easier. Couldn't we write a `fmt` for the enum and make it readable again?...

> I'll test it 👍🏻. Not sure how Substrate gets the name of the error TBH. You should expand a pallet once and check there.

Cc: @NunoAlexandre looks like an override issue.