John Muschelli

Let me know which way you'd like me to go with this. I think the passthrough is fine, but may be harder to maintain, but the above issues exist for...

That works as well. Either way, I’m just looking for something that will work with external git only, even if git2r is installed. And I think I’ve found all the...

Just seeing where this stands as we're currently relying on my branch for production

So should we implement this change or implement a `remotes.git` option? The reason I ask is without this change, we cannot install our private git packages correctly.

Remotes isn't doing anything wrong, devtools has the issue. I went to put an issue on devtools, but it says to choose remotes issues if it has to do with...

``` r remotes::install_git("[email protected]:tidyverse/stringr.git@dd909b7", git = "external") #> Downloading git repo [email protected]:tidyverse/stringr.git #> '/usr/bin/git' clone --depth 1 --no-hardlinks [email protected]:tidyverse/stringr.git /tmp/RtmpKlz895/file743a4ed8c6e6 #> '/usr/bin/git' fetch origin dd909b7 #> Warning in system(full, intern =...

Yeah I just saw that. I am using `sessioninfo::package_info` to get deps, so I guess I gotta get the full one. OK - good to close and kill the PR...

Killing this PR - but may be good to have a warning if "like" a short SHA?

This still does have an issue as the https://github.com/r-lib/remotes/blob/eb15a1eb21cca47ce5601747fd4e033d8606a648/R/install-git.R#L202 uses `archive` and this is an issue for `bitbucket` and `github` as well.

I believe it does, but do you think this solution would save some users who put a short SHA? Or maybe put a short SHA check with GH or bitbucket?...