John Muschelli

Results 107 comments of John Muschelli

Agreed - no YAML argument. Do you know what happens when a trigger is edited if it stays tied to specific builds?

It may be good to add `GOOGLE_APPLICATION_CREDENTIALS ` as that's the recommended way to set up for gloud SDK according to: https://cloud.google.com/docs/authentication/getting-started#setting_the_environment_variable

Added - it's difficult to provide a rich suite of tests given I don't have access to the specific projects referenced in the trigger tests.

Only failure seems to be a windows fail, not due to the code here.

Only failure seems to be a windows fail, not due to the code here.

I think that would work better in that case but this seems to pass and didn’t raise any flags, but it’s hard to know if you’ve gone down every …...

I think the issue is that if you specify `git` in `getOption`, the passthrough may still be needed. The issue is that `install_deps` has a `...` but `git` is not...

I think I've teased this out some more. The `getOption` solution will work, but can have a mismatch between the option and what executes depending on specifying `git` in the...

To summarize the behavior (with the `getOption("remotes.git", "auto")` proposed solution): Minimal change required: `git_remote` takes in `getOption("remotes.git", "auto")`. Then when you run: `install_git(..., git = "external")`, the repos passed here...