Tony Murray

We could skip calling the device observer code in the cases we don't want it. I believe when saving you add `withoutEvents`

Yeah, the daily.php changes are obviously correct in my opinion. The other changes requires a lot more thought and I'm not sure about it. The observer is for when the...

A couple of thoughts: 1. remove the daily process, I can't see how max depth would change outside of manual edit of device dependencies. 2. Possibly remove the device observer...

So, the purpose of the max depth field is to simplify polling (only used by fast ping at this time) in hierarchical order. If it is incorrect, it is not...

By the way, the reason I am resistant to your current implementation is that it is a lot of SQL queries (possibly n^2). I think it could be simplified and...

Unclear, can we merge the daily.php change so it is not held up by the other discussion?

This is probably ok for now. I didn't get to review the deferment code to see if it could be simplified.

I'm not sure if it is a good thing to add more options to the device add web page. I think it might be more appropriate to have an API...

I wonder how well this schema will apply when someone has millions of rows in the syslog table... Probably need to test that and maybe split up the into multiple...

How do you feel about making all user strings translatable? I consider it optional for your PR and could be done separately.