Tony Murray

Pulling out the script and making this PR just the cleanup.

Yes, to rebase this we need to drop the sort commit. I might just drop that anyway as it is risky. And sorting the modules differently changes behavior currently.

Finished up PR, removed the reformatting. That can be done separately if desired.

over time, we have been combining vendor specific tables into more generic ones with fields that work for both. Closest I can get to docs is to look at other...

Generally try to move from vendor specific modules to generic modules with a table structure that can support both. The Slas module is a recent example. There are probably others....

Looking pretty good over all. I would like to see another OS pulled in to make sure the database structure makes sense.

This looks good to me @eskyuu Sorry, my PR to remove cisco-voice means you need to rebase this.

If they are the same, this should use the bdcom os.

If they changed the enterprise number, it is fine as a separate OS or merged with fs-switch. FS's whole switch line is very difficult to figure out how to handle.