Tony Murray

Results 465 comments of Tony Murray

The thing about sorting by the display name is, that it is a template. This means it cannot be sorted in SQL. You would have to load them, parse all...

@mwobst This is typically what is stored in the database for the display field: `{{ $hostname }}`. Also, by default it is empty to fall back to the default setting:...

The display name tip is probably vague because it affects various layouts, not because there is a specific length limit of 512 or something. As I said before we want...

@SourceDoctor Probably need to add new a option. I think status is the only one that doesn't make sense.

I don't think the showing by one form of "hostname" and sorting by another makes sense...

#14329 I added "display name" as the default sort. Nothing else makes sense imo.

@SourceDoctor I already fixed that use case, see #14329

All it needed was when status is the sort, fallback to display name.

Additionally, the code should be a lot simpler (not as simple as it could be) to read now.

Nice, @gs-kamnas Any chance you could add some cases in `tests/Feature/TestScheduledMaintenance.php`? Actually, it does look like there are two commented out there, maybe just uncommenting them is enough.