Tony Murray

@gs-kamnas I uncommented the two test cases and they pass with your changes, so great :)

What is the use case for this, since the default is transparent? You can just make whatever is behind it yellow :D

If you want to limit the scope of this PR to be that only devices in these PRs are backed up, but still use the regular mapping to determine what...

@ottorei os mapping is ALWAYS configured by default, because our os names are not all the same as Oxidize's OS model names.

Still seems like you could get non-deterministic behavior when a device is in multiple groups. Also, why remove other maps when you could just replace the "group" map?

@ottorei FYI, you can use groups to assign credentials in oxidized.. so if the group is not right, auth will fail. You can map other fields too, can't think of...

@ottorei Been thinking too and I think a config array (where the order matters) will do just fine. But to make management easier for the user, in the device groups...

@ottorei I think I started to work on this, but got stuck on something and haven't had time. It may take some time before I get some time to look...

@rhinoau Yes, correct fix would be to add a check for empty hostnames before trying to lookup a dns record. I would probably even put it inside the deviceIsResolvable() function...

@banachtarski-91 any response?