Murisi Tarusenga
Murisi Tarusenga
> I'm going to close this, as I think we've decided to forgo this PR, still sound good @murisi? Here's a summary of the motivation for closing (@cwgoes): > >...
Another separate issue on the topic of IBC (N)FT Transfer (de)serialization: While most of the `Tx` data structure is serialized using Borsh, `MsgTransfer`s and `MsgNftTransfer`s are encoded by first Protobuf...
> why is this breaking the tx format? I think this is only breaking the `wasm` payload deserialization for the IBC txs no? My mistake here. You are correct. I've...
> @murisi Is this still required, or did ZondaX find a workaround? Zondax found a workaround. There's a certain byte they check in the Protobuf encoding. See: https://github.com/Zondax/ledger-namada/blob/6e0ac0f674ee3f9429244c7089fa31335e5f80af/app/src/parser_impl_txn.c#L853 .
Hi @vchong . Thank you for looking into this. We haven't released a compatible version of our app to the Ledger Live yet. In the meantime, for development purposes please...
> One small annoyance, the masp vp considers required authorizers all the addresses whose balance has decreased: this includes balances that had nothing to do with the MASP in that...
> > One small annoyance, the masp vp considers required authorizers all the addresses whose balance has decreased: this includes balances that had nothing to do with the MASP in...
> > The latest additions would work. But I wonder if there isn't a way to achieve outsourcing without having to augment `Transfer` with a vector of VP addresses... Might...
> can we close this? @murisi Yeah, we can close this. But for the sake of consistency, in the future we should probably consider using Borsh (de)seralization for the IBC...
> @murisi Is this list of review instructions still up-to-date? @cwgoes Yes the instructions are still up to date, but the attachments are now out of date. See attached the...