Results 40 comments of Murisi Tarusenga

> * I considered having a daemon process that would do such a thing. I think it's more work and will be more complicated to manage multiple process reading and...

> * The `SyncStatus` is there so the syncing and non-syncing related functions are actually implemented on separate types. This was especially helpful in making sure I had gotten rid...

When working with you on the note scanning algorithm, I noticed two things: 1. The `SyncStatus` caused friction in our SDK usage when we were trying to save the `ShieldedContext`....

@cwgoes I just want to clarify: is the goal to augment the `namadac --balance` command to indicate to the user how much of their balance is due to receiving MASP...

Ah, I see. This should be straightforward. This is the variable that holds the total reward to be distributed on an epoch boundary: https://github.com/anoma/namada/blob/5a5838a528ace84c03a1dfc818a50450f6d09459/crates/shielded_token/src/conversion.rs#L288 . We just need to accumulate...

@cwgoes Reviewing the changes in https://github.com/anoma/namada/pull/3356 made me revisit this issue. > but the way things are structured is very confusing, e.g. setting amount and token to sentinel amounts for...

> Excellent points - this issue preceded transfer vectorization, and I hadn't considered the combination of the two at the time. > > > A potentially simpler approach to achieve...

Hi @dan-u410 . Thank you for brining these issues up! Over the next few days I'll try to reproduce them and reduce the need for a local node in some...

> I'm very much in favor of this PR as it simplifies the shielded rewards logic but we'll need to wait for someone to review the economic outcomes of it...

> Actually, one small thing, I believe we need to review and update the shielded rewards estimate function: > > https://github.com/anoma/namada/blob/102adbbef0881d79ca3c82acfee15ec71d057dfe/crates/shielded_token/src/masp/shielded_wallet.rs#L692 > > We were handling the rewards with `Epoch(0)`...