Munieru

Results 22 comments of Munieru

ReactやVue.jsのドキュメントのように、「このページを編集する」「GitHub上で編集する」のようなテキストがあれば分かりやすいかと思います。 もっとも、そうであれば本家ドキュメントも「Edit this page」「Edit on GitHub」のようになっていてほしいですが…… ## 参考リンク - https://ja.reactjs.org/docs/getting-started.html - https://jp.vuejs.org/v2/guide/

How about using other more popular libraries (e.g. [date-fns](https://npmjs.com/package/date-fns), [dayjs](https://npmjs.com/package/dayjs))? https://www.npmtrends.com/date-fns-vs-dayjs-vs-luxon cf. https://github.com/you-dont-need/You-Dont-Need-Momentjs

@rarkins I would be able to do it because there are few places where Luxon is used in this repository. However, it will take some time.

@rarkins Luxon is used in 18 files now. Show used functions per files - `lib/modules/datasource/metadata.ts` - `fromISO` - `isValid` - `toISO` - `lib/modules/datasource/maven/index.ts` - `fromFormat` - `isValid` - `toISO` -...

@rarkins > I'm leaning towards date-fns. What do you think? And When I deal with dates in JS, I prefer to use date-fns because it is easy to use since...

@viceice dayjs seem to be much smaller in size than Luxon. - Luxon: 70.8 KB - dayjs: 6.4KB https://github.com/you-dont-need/You-Dont-Need-Momentjs#brief-comparison However, I have not actually checked.

jsonc? ```jsonc "angularCompilerOptions": { /* ... */ "debug": true } ``` https://code.visualstudio.com/docs/languages/json#_json-with-comments

It seems that we need to buy to see it... 💸 https://www.iso.org/standard/70908.html

I think `toISO` method should always return general format (like `P7D`). And we can add other method such as `toISOWeeks` for weeks format (like `P1W`).

@leebickmtu >What about a second Boolean parameter on toISO which enables it? But still only if just weeks is defined. It's nice idea 😄