Tim Möhlmann

Results 284 comments of Tim Möhlmann

Fails on [staticcheck](https://builds.sr.ht/~mdlayher/job/171417#task-build-47), on lines not affected by this PR. Note, running staticcheck against `master` produces the same errors.

I was in the misunderstanding that Go examples are always ran. I've removed the output requirement and the examples no longer run. `wg0` is now used. Before, I used the...

I've updated this PR to catch the nil in `userinfo.UnmarshalJSON` and set a new empty value to the `userinfo.Address` field. The original change in `userinfo.GetAddress()` is reverted. And the tests...

@andradei. It seems that using `qm.Select` confuses `qm.Load` if the relational `id` columns are omitted. So consider writing the above as: ```` s, err := models.Somethings( qm.Load(models.SomethingRels.Dad, qm.Select("id", "name")), qm.Load(models.SomethingRels.Mom,...

We have a similar use case. I have an auto merge rule for "regular" pull requests, needing 2 reviews. Then a second rule which matches a group of "trusted" contributors...

Also tried to set `mergify[bot]` as the only user that is allowed to do merges, but Github does not recognize it as a username.

> Well, it should be breaking. However, using reflection to detect nil here looks a bit strange... It's like embedding workaround right into codebase instead of fixing) Any interface type...

Please discard the rant above. I missed the fact that we can just return an empty instance of userInfoAddress in case of nil, with no further complications. ``` func (u...

@livio-a , yes you are right. I've adjusted the tests to use actual json and I was able to reproduce the same panic. There are two options to fix this:...