Tim Möhlmann
Tim Möhlmann
@muir if you have some time, I'm curious how this [upgrade script](https://github.com/zitadel/oidc/blob/upgrade-guide/UPGRADING.md#full-script) works on other repositories. As zitadel does not use all affected symbols some `sed` commands are just guesswork....
@muir thanks for checking and feedback! We will update to Go 1.22 and drop 1.20 support soon. With that I will move all the logging imports to `log/slog`.
The standard is a bit fishy on this. > it SHOULD NOT have a nonce Claim, even when the ID Token issued at the time of the original authentication contained...
Sorry lost track of this issue. With the above arguments you gave I agree that we can allow an empty nonce. Do you want to send a PR for that?
Yes, I wrote I agree ;)
> I looked into it and since the ValidToken function does not know the context of the token source (comming from CodeExchange or Refresh), I have no clue how I...
If you want to use the `op.Provider`, you need to implement the `op.Storage` interface. Storage does not have to be static. If we look specifically at: https://github.com/zitadel/oidc/blob/8d0819ee8ac9fa537b6b3b417118cc8dd99608d9/pkg/op/storage.go#L111-L124 You could implement...
As we now have a the new server interface, this allows you to implement the OP however you want. We now also have wildcard support. Will now close this issue...
@livio-a it seems that the error fix you were looking for got reverted upstream, because it became a breaking change: https://github.com/zitadel/oidc/pull/625
Thanks for pointing it out. We will discuss. CC @livio-a