Results 271 comments of Matthew Treinish
trafficstars

Yeah adding the validation job is a good idea, that will prevent this in the future. (and since I'm apparently the typical cause of these issues it'll be good to...

Yes I think a reno release note would be appropriate here, I would say add two notes as features, one documenting the addition of the empty graph functions and the...

I think this is ready (assuming the gha outage https://www.githubstatus.com/incidents/smn1qtqvbsb6 ends soon and everything passes CI). Once this merges I think we're ready to tag and release 0.12.0

This one isn't as easy to solve as it might appear. This is basically a limit of how interfaces to python need to be built, You're pretty much correct it's...

> Overall I really like this idea. I added several comments. My main questions are > > * What would be the best place to host this code? Seems like...

> I am not sure I follow the logic here. There is a `BaseSampler` that targets a statevector simulator, which is not really a sampling routine at all, and because...

Looks like the conversion behavior changed in pyo3 0.17.0: ``` test.python.result.test_counts.TestCounts.test_marginal_distribution_numpy_indices ---------------------------------------------------------------------------------- Captured traceback: ~~~~~~~~~~~~~~~~~~~ Traceback (most recent call last): File "/tmp/terra-tests/test/python/result/test_counts.py", line 60, in test_marginal_distribution_numpy_indices result = utils.marginal_distribution(counts_obj, indices)...

I've marked this as for 0.23.0 although I don't think there is actually a blocker for including it as part of 0.22.0. However, since the 0.22.0.rc1 is pending I say...

There is ongoing work on adding a new plugin interface for more general synthesizing higher level objects like linear functions as a dual of the unitary synthesis plugin interface. You...

The `repr()` function (and by extension the return from `__repr__`) is expected to return a string representation that can be passed to `eval()` which python will execute and create an...