Results 294 comments of Matthew Treinish

Also, as discussed in https://github.com/Qiskit/qiskit-terra/issues/5775#issuecomment-789808980 it would be good if this implementation could handle the peephole optimization special case outlined in section 5.4.2 of the paper (the actual optimization will...

Heh, I started a review earlier this morning and the pending comment that I left before I had to step away was asking if we could make it generic for...

I'm fine with that, I don't think this is critical for the 0.11.0 release nothing is blocked. It'd be nice to have (especially considering it was opened > 4 months...

Where are you running from? A common trap for python is that if there is a directory with an `__init__.py` file in your current working directory Python will use that...

I meant `rustworkx/__init__.py` which is looks like is the case here. If python detects a local directory that looks like a python package (meaning it has an `__init__.py` in it)...

For the question about `extend_from_weighted_edge_list()` floats are definitely allowed for the weight parameter in the input tuples. In fact there are no constraints placed on a edge (or node) weight...

There's not a lot of context here, I had never heard of the disutils record feature before. The only hits I found on google were from issues you opened on...

Thanks for opening an issue. I think we can probably look at adding functions for working with percolation there are definitely applications for it. But could you provide some more...

Yeah, this is a good catch. We should be reconstructing the edge indices exactly via `__getstate__` and `__setstate__` right now it doesn't do that. I think probe the only catch...

It's still a work in progress (hence the `WIP` prefix), it's still failing one of the tests I wrote too. I pushed up the commit to my fork mostly for...