Manu Sridharan

Results 671 comments of Manu Sridharan

So sorry for my slow response. I see how jQuery would cause an issue with your solution. What I was wondering was are you seeing this issue of a variable...

Sorry to hear about your accident, and glad that you've recovered! As noted originally, this problem arises when there are both a variable and a function statement with the same...

I have a possibly simpler temporary workaround. It looks like `esnstrument.js` supports a configuration function `INSTR_TRY_CATCH_ARGUMENTS` to configure whether the try-catch blocks are inserted: https://github.com/Samsung/jalangi2/blob/7f0be09ebc2c3f223071eeb5a3f9e7b513d9304d/src/js/instrument/esnstrument.js#L948 Could you try uncommenting this...

That flag should remove both the try-catch and the while loop. Too bad it doesn't work right now. Where do you get the IllegalStateException? During instrumentation, or while running the...

So it seems the `INSTR_TRY_CATCH_ARGUMENTS` setting is bitrotted; I didn't see a quick fix for the above issue. I still think further function hoisting is the best solution we've come...

@gogo9th could you open a pull request with your changes? That will make them a lot easier to read. If you could include your tests in the PR, even better....

Thanks @MadhuNimmo. The original code relies on the fact that calling `toString()` on a `Function` prints its code. After instrumentation, the output of `toString()` changes (to be the instrumented code),...

@soufianos01 thanks for the report. I wonder if there is some recent regex feature that our version of Acorn doesn't support and we need to update. Or maybe there is...

@ksen007 would a solution be to strip any use of `"use strict"` from an instrumented file?

@gogo9th yes that is a tricky scenario. The only thing I can think of would be to make Jalangi's use of `arguments.callee` optional. It's not too obvious to me how...